659 Star 2.2K Fork 803

GVPShardingSphere / Apache ShardingSphere

 / 详情

[初级] 代码重构:移除 Proxy 的枚举 TransactionOperationType

Backlog
Opened this issue  
2021-05-14 18:38

目标

移除枚举类 org.apache.shardingsphere.transaction.core.TransactionOperationType

思路

梳理如下两个类的逻辑,考虑如何用 TCLStatement 判断事务相关逻辑。

  • org.apache.shardingsphere.proxy.backend.text.transaction.TransactionBackendHandler
  • org.apache.shardingsphere.proxy.backend.text.transaction.TransactionBackendHandlerFactory

步骤

  1. 移除 org.apache.shardingsphere.transaction.core.TransactionOperationType
  2. TransactionBackendHandler 内部通过判断 TCLStatement 控制执行逻辑;
  3. 调整并完善单元测试。

Comments (1)

吴伟杰 created任务
吴伟杰 changed description
吴伟杰 changed description
Expand operation logs

本地拉了代码发现了TransactionOperationType还被AbstractShardingTransactionManagerFixture引用了,可能还要考虑这个类的功能改造

I pull master branch to handle #I3RDGW:[初级] 代码重构:移除 Proxy 的枚举 TransactionOperationType,but I found AbstractShardingTransactionManagerFixture dependents on TransactionOperationType.

Sign in to comment

Status
Assignees
Milestones
Pull Requests
Successfully merging a pull request will close this issue.
Branches
Planed to start   -   Planed to end
-
Top level
Priority
参与者(2)
5103752 throwabledoge 1602603893
Java
1
https://gitee.com/Sharding-Sphere/sharding-sphere.git
git@gitee.com:Sharding-Sphere/sharding-sphere.git
Sharding-Sphere
sharding-sphere
Apache ShardingSphere

Search