diff --git a/inc/graphengine/inc/framework/common/string_util.h b/inc/graphengine/inc/framework/common/string_util.h index f03683633b8ecd344c9a46740461678a6e51bb97..c1216d90aae4581e650d14df679afc0dec5c95c3 100644 --- a/inc/graphengine/inc/framework/common/string_util.h +++ b/inc/graphengine/inc/framework/common/string_util.h @@ -45,18 +45,21 @@ class GE_FUNC_VISIBILITY StringUtils { public: static std::string &Ltrim(std::string &s) { #if __cplusplus >= 201103L - (void)s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](int c) { return !std::isspace(c); })); + (void)s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](const int32_t c) { return std::isspace(c) == 0; })); #else - (void)s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun(std::isspace)))); + (void)s.erase(s.begin(), std::find_if(s.begin(), s.end(), + std::not1(std::ptr_fun(std::isspace)))); #endif return s; } // lint -esym(551,*) static std::string &Rtrim(std::string &s) { /*lint !e618*/ #if __cplusplus >= 201103L - (void)s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](int c) { return !std::isspace(c); })); + (void)s.erase(std::find_if(s.rbegin(), s.rend(), [](const int32_t c) { return std::isspace(c) == 0; }).base(), + s.end()); #else - (void)s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun(std::isspace))).base(), s.end()); + (void)s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun(std::isspace))).base(), + s.end()); #endif return s; } diff --git a/tf_adapter/tests/st/optimizers/testcase/om_partition_subgraphs_pass_test.cc b/tf_adapter/tests/st/optimizers/testcase/om_partition_subgraphs_pass_test.cc index 38e0704299108191e82e5d966ed9b68a867a4fcd..53c4eb0e4bf5f451db5e0aaed235cbe9bb46d7c4 100644 --- a/tf_adapter/tests/st/optimizers/testcase/om_partition_subgraphs_pass_test.cc +++ b/tf_adapter/tests/st/optimizers/testcase/om_partition_subgraphs_pass_test.cc @@ -212,7 +212,7 @@ TEST_F(OmOptimizationPassTest, StringInputMaxSizeTest) { std::string target_graph = DoRunOmOptimizationPassTest(); EXPECT_EQ(target_graph, "arg_input_0_0->DecodeJpeg;DecodeJpeg->retval_DecodeJpeg_0_0"); } -TEST_F(OmOptimizationPassTest, NpuOpsIdentifierTest01) { +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest01) { SetLogLevelForC(0); std::string opp_path = __FILE__; opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; @@ -224,7 +224,78 @@ TEST_F(OmOptimizationPassTest, NpuOpsIdentifierTest01) { system(("mkdir -p " + path_vendors).c_str()); system(("echo 'load_priority=customize,mdc,lhisi' > " + path_config).c_str()); std::vector vendors; - NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors); + EXPECT_TRUE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 3); + EXPECT_EQ(vendors[0], "customize"); + EXPECT_EQ(vendors[1], "mdc"); + EXPECT_EQ(vendors[2], "lhisi"); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest02) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo '' > " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest03) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo 'load_priority' > " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest04) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("rm -rf " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest05) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo ' load_priority = customize , mdc , lhisi ' > " + path_config).c_str()); + std::vector vendors; + EXPECT_TRUE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); EXPECT_EQ(vendors.size(), 3); EXPECT_EQ(vendors[0], "customize"); EXPECT_EQ(vendors[1], "mdc"); diff --git a/tf_adapter/tests/ut/optimizers/testcase/om_partition_subgraphs_pass_test.cc b/tf_adapter/tests/ut/optimizers/testcase/om_partition_subgraphs_pass_test.cc index 38e0704299108191e82e5d966ed9b68a867a4fcd..53c4eb0e4bf5f451db5e0aaed235cbe9bb46d7c4 100644 --- a/tf_adapter/tests/ut/optimizers/testcase/om_partition_subgraphs_pass_test.cc +++ b/tf_adapter/tests/ut/optimizers/testcase/om_partition_subgraphs_pass_test.cc @@ -212,7 +212,7 @@ TEST_F(OmOptimizationPassTest, StringInputMaxSizeTest) { std::string target_graph = DoRunOmOptimizationPassTest(); EXPECT_EQ(target_graph, "arg_input_0_0->DecodeJpeg;DecodeJpeg->retval_DecodeJpeg_0_0"); } -TEST_F(OmOptimizationPassTest, NpuOpsIdentifierTest01) { +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest01) { SetLogLevelForC(0); std::string opp_path = __FILE__; opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; @@ -224,7 +224,78 @@ TEST_F(OmOptimizationPassTest, NpuOpsIdentifierTest01) { system(("mkdir -p " + path_vendors).c_str()); system(("echo 'load_priority=customize,mdc,lhisi' > " + path_config).c_str()); std::vector vendors; - NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors); + EXPECT_TRUE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 3); + EXPECT_EQ(vendors[0], "customize"); + EXPECT_EQ(vendors[1], "mdc"); + EXPECT_EQ(vendors[2], "lhisi"); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest02) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo '' > " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest03) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo 'load_priority' > " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest04) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("rm -rf " + path_config).c_str()); + std::vector vendors; + EXPECT_FALSE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); + EXPECT_EQ(vendors.size(), 0); + ClearLogLevelForC(); + system(("rm -rf " + opp_path).c_str()); +} +TEST_F(OmOptimizationPassTest, GetOppPluginVendorsTest05) { + SetLogLevelForC(0); + std::string opp_path = __FILE__; + opp_path = opp_path.substr(0, opp_path.rfind("/") + 1) + "opp_path/"; + setenv("ASCEND_OPP_PATH", opp_path.c_str(), 1); + std::string path_builtin = opp_path + "built-in"; + std::string path_vendors = opp_path + "vendors"; + std::string path_config = path_vendors + "/config.ini"; + system(("mkdir -p " + path_builtin).c_str()); + system(("mkdir -p " + path_vendors).c_str()); + system(("echo ' load_priority = customize , mdc , lhisi ' > " + path_config).c_str()); + std::vector vendors; + EXPECT_TRUE(NpuOpsIdentifier::GetOppPluginVendors(path_config, vendors)); EXPECT_EQ(vendors.size(), 3); EXPECT_EQ(vendors[0], "customize"); EXPECT_EQ(vendors[1], "mdc"); diff --git a/tf_adapter/util/npu_ops_identifier.cc b/tf_adapter/util/npu_ops_identifier.cc index e2b504552f53c30d031f8b99c8df6ac952482467..ada3082f303578375d1274dae606479f1709343d 100644 --- a/tf_adapter/util/npu_ops_identifier.cc +++ b/tf_adapter/util/npu_ops_identifier.cc @@ -74,6 +74,7 @@ bool NpuOpsIdentifier::GetOppPluginVendors(const std::string &vendors_config, st ADP_LOG(ERROR) << "Format of file content is invalid!"; return false; } + (void) for_each(vendors.begin(), vendors.end(), &ge::StringUtils::Trim); return true; }