0 Star 0 Fork 0

iducn / House

 / 详情

using find_package for swig, and set version control

待办的
拥有者
创建于  
2021-03-24 16:01

源自github用户backyes:
more robust cmake for swig

  • add version control while looking for swig with cmake, otherwise, some unreadable error comes.

The BUG is related with:
https://github.com/baidu/Paddle/issues/259

@reyoung Please do some code review.

@王小花不瞎搞 You can determine if this PR should be merged into milestone 0.8.1.

评论 (13)

iducn 创建了任务
iducn 关联仓库设置为iducn/House
展开全部操作日志

源自github用户backyes:
@reyoung suggest using QUIET for looking for swig. Just follow his comment.

源自github用户reyoung:
Why should this PR be a bug?

We handcraft the find swig method, before. And using find(SWIG 3.0) just update the swig version from 2.X to 3.0. So, there are two things I am confused.

  • find(SWIG 3.0) should be as same as we set set(MIN_SWIG_VERSION 2) to set(MIN_SWIG_VERSION 3). Am I right for this?
  • Is the Paddle using some swig 3.0 feature that cause swig 2.x cannot be used?

源自github用户backyes:
有个用户场景下, 在make阶段出现了一些关于swig的异常具,具体的错误并没有记录。另外, 既然cmake有swig的find_package,且能对版本控制,建议改成patch后的形式。
感觉没有必要对这些影响不大的问题,反复确认。

源自github用户reyoung:
@backyes I approve using the find(SWIG). I just want to know, why you upgrade the swig 2.x to 3.0? Is there any bug before? Could you provide more details for this bug?

源自github用户reyoung:
@backyes Upgrade the dependency version will cause we lack of support some old linux distro. Like CentOS 7, CentOS 6.X. I just need to ensure these linux distro support SWIG 3.0 if you upgrade SWIG version.

It is important for us.

源自github用户reyoung:
@QiJune The default swig in CentOS 7.0, is swig 2.0. Is there any trouble when you build RPM package in CentOS 7 by using swig 2.0 ?

image

源自github用户backyes:
@reyoung Swig 2.0 can satisfy current requirement, so use find_package(SWIG 2.0) instead.

Also rename swig.cmake->py_paddle instead, since swig.cmake will own nothing about SWIG tool except py_paddle related function.

源自github用户reyoung:
@backyes Actually, swig.cmake should not be renamed. Because in general, the swig part of paddle, will not just support only python, but many other language, see #258:paddle.trainer .config_parser

源自github用户reyoung:
@backyes Sorry, the cmake support for RDMA PR has been check in, then make this PR conflict to develop branch. Please resolve the conflicts, and tell me to merge.

源自github用户coveralls:
Coverage Status

Coverage decreased (-0.005%) to 62.35% when pulling 80369e22747f78539f396a7fb402d438c76cdd0a on backyes:bugfix_swig into 744dba4abdedd74504c613d408221c075acc8cb9 on baidu:develop.

登录 后才可以发表评论

状态
负责人
里程碑
Pull Requests
关联的 Pull Requests 被合并后可能会关闭此 issue
分支
开始日期   -   截止日期
-
置顶选项
优先级
参与者(1)
4994586 iducn3 1600758993
Python
1
https://gitee.com/iducn3/House.git
git@gitee.com:iducn3/House.git
iducn3
House
House

搜索帮助