diff --git a/.gitee/PULL_REQUEST_TEMPLATE.en.md b/.gitee/PULL_REQUEST_TEMPLATE.en.md index 52764caf805f40f63f0c77efe1fe038a222dbac2..e031c6f556854d60746c6f12636411c24fcc8f69 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.en.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.en.md @@ -15,6 +15,7 @@ If this pr is not only bugfix/task/feature and also a refactor, you can append ` **What does this PR do / why do we need it**: +* Need to describe clearly **Which issue(s) this PR fixes**: @@ -25,13 +26,17 @@ Usage: `Fixes #`, or `Fixes (paste link of issue)`. Fixes # -**Code review checklist [[illustration]](https://gitee.com/mindspore/community/blob/master/security/code_review_checklist_mechanism.md)**: +**What scenarios were tested, and what were the verification results（Function, performance, reliability, etc.）**： +* Need to describe clearly -+ - [ ] whether to verify the function's return value (It is forbidden to use void to mask the return values of security functions and self-developed functions. C++ STL functions can be masked if there is no problem) -+ - [ ] Whether to comply with ***SOLID principle / Demeter's law*** -+ - [ ] Whether there is UT test case && the test case is a valid (if there is no test case, please explain the reason) -+ - [ ] Whether the API change is involved -+ - [ ] Whether official document modification is involved + +**Self-checklist**:（**Please check carefully,and mark an x in the [] brackets. We will review your completion status.**） + ++ - [ ] **Design**: Has the solution corresponding to the PR been reviewed by the Maintainer, and have all review comments been replied to and revised ++ - [ ] **Test**: Has the code in the PR been fully covered by UT/ST test cases, and have the newly added test cases been uploaded to the repository along with this PR or already uploaded. ++ - [ ] **Verification**: Does the PR description contains a detailed description of the verification results regarding the achievement of the expected goals for the Feature, Refactor, and Bugfix to this PR. ++ - [ ] **Interface**: Does it involve changes to external interfaces? The corresponding changes have been approved by the interface review organization, and the annotation information for the API has been correctly refreshed. ++ - [ ] **Document**: Does it involve modifications to the official website documentation? If so, please submit the materials to the Doc repository in a timely manner. diff --git a/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md b/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md index 1d55805cf51706d5575810c72c86597fcc9eefed..97e6a4404ee6a99d64e4a16f6907f51b2c72034d 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.zh-CN.md @@ -12,13 +12,16 @@ - /kind task - /kind feature - /kind refactor +- /kind clean_code 如PR描述不符合规范，修改PR描述后需要/check-pr重新检查PR规范。 --> /kind