From 256e4db4d4975396ae7d89f6aa21c46a16e3623f Mon Sep 17 00:00:00 2001 From: Christophe JAILLET Date: Tue, 18 Feb 2025 15:10:34 +0800 Subject: [PATCH] crypto: caam - Fix the pointer passed to caam_qi_shutdown() stable inclusion from stable-v5.10.231 commit cc386170b3312fd7b5bc4a69a9f52d7f50814526 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBEGFF CVE: CVE-2024-56754 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=cc386170b3312fd7b5bc4a69a9f52d7f50814526 -------------------------------- [ Upstream commit ad980b04f51f7fb503530bd1cb328ba5e75a250e ] The type of the last parameter given to devm_add_action_or_reset() is "struct caam_drv_private *", but in caam_qi_shutdown(), it is casted to "struct device *". Pass the correct parameter to devm_add_action_or_reset() so that the resources are released as expected. Fixes: f414de2e2fff ("crypto: caam - use devres to de-initialize QI") Signed-off-by: Christophe JAILLET Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin Signed-off-by: Zhang Zekun --- drivers/crypto/caam/qi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c index ec53528d8205..8e9f6097114e 100644 --- a/drivers/crypto/caam/qi.c +++ b/drivers/crypto/caam/qi.c @@ -768,7 +768,7 @@ int caam_qi_init(struct platform_device *caam_pdev) caam_debugfs_qi_init(ctrlpriv); - err = devm_add_action_or_reset(qidev, caam_qi_shutdown, ctrlpriv); + err = devm_add_action_or_reset(qidev, caam_qi_shutdown, qidev); if (err) return err; -- Gitee