From 09bd7af955743886e8a3043a3fde6fc0a2ce4c56 Mon Sep 17 00:00:00 2001 From: Miaoqian Lin Date: Fri, 7 Mar 2025 10:13:16 +0800 Subject: [PATCH] powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup stable inclusion from stable-v4.19.247 commit 5b8aa2ba38c010f47c965dd9bb5a8561813ed649 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP5WK CVE: CVE-2022-49439 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=5b8aa2ba38c010f47c965dd9bb5a8561813ed649 -------------------------------- [ Upstream commit fcee96924ba1596ca80a6770b2567ca546f9a482 ] of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: abc3aeae3aaa ("fsl-rio: Add two ports and rapidio message units support") Signed-off-by: Miaoqian Lin Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220512123724.62931-1-linmq006@gmail.com Signed-off-by: Sasha Levin Signed-off-by: Huang Xiaojia --- arch/powerpc/sysdev/fsl_rio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c index 5011ffea4e4b3..c48ebe6779622 100644 --- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c @@ -509,8 +509,10 @@ int fsl_rio_setup(struct platform_device *dev) if (rc) { dev_err(&dev->dev, "Can't get %pOF property 'reg'\n", rmu_node); + of_node_put(rmu_node); goto err_rmu; } + of_node_put(rmu_node); rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs)); if (!rmu_regs_win) { dev_err(&dev->dev, "Unable to map rmu register window\n"); -- Gitee