diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index af9fea93b48831a56a912eaf58d7ab2fa9bad668..8c0c4cea89c3135d3730c273e502c779c9787d32 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -153,11 +153,8 @@ bpf_trampoline_get_progs(const struct bpf_trampoline *tr, int *total) return tprogs; } -static void __bpf_tramp_image_put_deferred(struct work_struct *work) +static void bpf_tramp_image_free(struct bpf_tramp_image *im) { - struct bpf_tramp_image *im; - - im = container_of(work, struct bpf_tramp_image, work); bpf_image_ksym_del(&im->ksym); bpf_jit_free_exec(im->image); bpf_jit_uncharge_modmem(1); @@ -165,6 +162,14 @@ static void __bpf_tramp_image_put_deferred(struct work_struct *work) kfree_rcu(im, rcu); } +static void __bpf_tramp_image_put_deferred(struct work_struct *work) +{ + struct bpf_tramp_image *im; + + im = container_of(work, struct bpf_tramp_image, work); + bpf_tramp_image_free(im); +} + /* callback, fexit step 3 or fentry step 2 */ static void __bpf_tramp_image_put_rcu(struct rcu_head *rcu) { @@ -319,7 +324,7 @@ static int bpf_trampoline_update(struct bpf_trampoline *tr) &tr->func.model, flags, tprogs, tr->func.addr); if (err < 0) - goto out; + goto out_free; WARN_ON(tr->cur_image && tr->selector == 0); WARN_ON(!tr->cur_image && tr->selector); @@ -330,7 +335,7 @@ static int bpf_trampoline_update(struct bpf_trampoline *tr) /* first time registering */ err = register_fentry(tr, im->image); if (err) - goto out; + goto out_free; if (tr->cur_image) bpf_tramp_image_put(tr->cur_image); tr->cur_image = im; @@ -338,6 +343,10 @@ static int bpf_trampoline_update(struct bpf_trampoline *tr) out: kfree(tprogs); return err; + +out_free: + bpf_tramp_image_free(im); + goto out; } static enum bpf_tramp_prog_type bpf_attach_type_to_tramp(struct bpf_prog *prog)