From 790b085dfcef557dd8771cb290b73026b2435ea7 Mon Sep 17 00:00:00 2001 From: Zhang Changzhong Date: Wed, 29 Oct 2025 12:18:56 +0800 Subject: [PATCH] wifi: brcmfmac: fix potential memory leak in brcmf_netdev_start_xmit() stable inclusion from stable-v4.19.276 commit e5d01e85cf46628647cd696cb72ba4659b18967f category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/ICY4C7 CVE: CVE-2022-50321 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e5d01e85cf46628647cd696cb72ba4659b18967f -------------------------------- [ Upstream commit 212fde3fe76e962598ce1d47b97cc78afdfc71b3 ] The brcmf_netdev_start_xmit() returns NETDEV_TX_OK without freeing skb in case of pskb_expand_head() fails, add dev_kfree_skb() to fix it. Compile tested only. Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()") Signed-off-by: Zhang Changzhong Reviewed-by: Arend van Spriel Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/1668684782-47422-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Sasha Levin Signed-off-by: Wang Liang --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 5de20e5d67b6..e340df13681c 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -313,6 +313,7 @@ static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb, brcmf_err("%s: failed to expand headroom\n", brcmf_ifname(ifp)); atomic_inc(&drvr->bus_if->stats.pktcow_failed); + dev_kfree_skb(skb); goto done; } } -- Gitee