From fea39c5dac74278f79cad3108071e5c1eeb0af5b Mon Sep 17 00:00:00 2001 From: YueHaibing Date: Wed, 6 Dec 2023 13:40:39 +0800 Subject: [PATCH] net: txgbe: Fix memleak in txgbe_calc_eeprom_checksum() mainline inclusion from mainline-v6.2-rc1 commit a068d33e542f5d5be2e5de3cf1122c4347d3e2af category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8LOJU Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a068d33e542f5d5be2e5de3cf1122c4347d3e2af -------------------------------- eeprom_ptrs should be freed before returned. Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware") Signed-off-by: YueHaibing Signed-off-by: Jakub Kicinski Signed-off-by: Dapeng Yu --- drivers/net/ethernet/netswift/txgbe/txgbe_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netswift/txgbe/txgbe_hw.c b/drivers/net/ethernet/netswift/txgbe/txgbe_hw.c index 55f98a55f4b6..929f03c42132 100644 --- a/drivers/net/ethernet/netswift/txgbe/txgbe_hw.c +++ b/drivers/net/ethernet/netswift/txgbe/txgbe_hw.c @@ -6925,6 +6925,7 @@ s32 txgbe_calc_eeprom_checksum(struct txgbe_hw *hw) eeprom_ptrs); if (status) { DEBUGOUT("Failed to read EEPROM image\n"); + kvfree(eeprom_ptrs); return status; } local_buffer = eeprom_ptrs; -- Gitee