From 0bed9f33d4b69f605163bce07a8023789c3629a7 Mon Sep 17 00:00:00 2001 From: Nikita Kiryushin Date: Fri, 24 May 2024 11:16:58 +0800 Subject: [PATCH] ACPI: LPIT: Avoid u32 multiplication overflow stable inclusion from stable-v5.10.209 commit f39c3d578c7d09a18ceaf56750fc7f20b02ada63 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9Q9HZ CVE: CVE-2023-52683 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f39c3d578c7d09a18ceaf56750fc7f20b02ada63 -------------------------------- [ Upstream commit 56d2eeda87995245300836ee4dbd13b002311782 ] In lpit_update_residency() there is a possibility of overflow in multiplication, if tsc_khz is large enough (> UINT_MAX/1000). Change multiplication to mul_u32_u32(). Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: eeb2d80d502a ("ACPI / LPIT: Add Low Power Idle Table (LPIT) support") Signed-off-by: Nikita Kiryushin Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin Signed-off-by: Wang Hai Signed-off-by: Xiongfeng Wang --- drivers/acpi/acpi_lpit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c index 48e5059d67ca..7de59730030c 100644 --- a/drivers/acpi/acpi_lpit.c +++ b/drivers/acpi/acpi_lpit.c @@ -98,7 +98,7 @@ static void lpit_update_residency(struct lpit_residency_info *info, struct acpi_lpit_native *lpit_native) { info->frequency = lpit_native->counter_frequency ? - lpit_native->counter_frequency : tsc_khz * 1000; + lpit_native->counter_frequency : mul_u32_u32(tsc_khz, 1000U); if (!info->frequency) info->frequency = 1; -- Gitee