From 4eef4c70265c7f965eebe35a3da9eebf38137a34 Mon Sep 17 00:00:00 2001 From: muratcimen_9be2 Date: Wed, 6 Aug 2025 09:34:54 +0300 Subject: [PATCH] distinct-unsigned-right-shift-negative-number Issue: https://gitee.com/openharmony/arkcompiler_ets_frontend/issues/ICQDPB Signed-off-by: muratcimen_9be2 --- ets2panda/linter/rule-config.json | 1 + ets2panda/linter/src/lib/CookBookMsg.ts | 2 + ets2panda/linter/src/lib/FaultAttrs.ts | 1 + ets2panda/linter/src/lib/FaultDesc.ts | 1 + ets2panda/linter/src/lib/Problems.ts | 1 + ets2panda/linter/src/lib/TypeScriptLinter.ts | 36 ++++++++++++ ets2panda/linter/src/lib/utils/TsUtils.ts | 8 +++ .../main/arkts-unsigned-shift-on-negative.ets | 26 +++++++++ ...s-unsigned-shift-on-negative.ets.args.json | 19 ++++++ ...unsigned-shift-on-negative.ets.arkts2.json | 58 +++++++++++++++++++ .../arkts-unsigned-shift-on-negative.ets.json | 18 ++++++ 11 files changed, 171 insertions(+) create mode 100644 ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets create mode 100644 ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.args.json create mode 100644 ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.arkts2.json create mode 100644 ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.json diff --git a/ets2panda/linter/rule-config.json b/ets2panda/linter/rule-config.json index b4a9e330ed..9e46cca4ad 100644 --- a/ets2panda/linter/rule-config.json +++ b/ets2panda/linter/rule-config.json @@ -65,6 +65,7 @@ "arkts-no-sparse-array", "arkts-no-enum-prop-as-type", "arkts-no-ts-like-smart-type", + "arkts-distinct-unsigned-right-shift-negative-number", "arkts-array-type-immutable", "arkts-primitive-type-normalization", "arkts-no-ts-like-catch-type", diff --git a/ets2panda/linter/src/lib/CookBookMsg.ts b/ets2panda/linter/src/lib/CookBookMsg.ts index 3aafa7ae52..0e459788e5 100644 --- a/ets2panda/linter/src/lib/CookBookMsg.ts +++ b/ets2panda/linter/src/lib/CookBookMsg.ts @@ -302,6 +302,8 @@ cookBookTag[271] = 'After a variable is declared, a value must be assigned before using it (arkts-var-assignment-before-use)'; cookBookTag[272] = 'This API of process is obsolete in ArkTS 1.1. It\'s no longer supported in ArkTS 1.2 (arkts-concurrent-deprecated-apis)'; +cookBookTag[273] = + 'Unsigned right shift on negative number yields different results in ArkTS versions. (arkts-distinct-unsigned-right-shift-negative-number)'; cookBookTag[274] = 'The subclass constructor must call the parent class\'s parametered constructor (arkts-subclass-must-call-super-constructor-with-args)'; cookBookTag[275] = diff --git a/ets2panda/linter/src/lib/FaultAttrs.ts b/ets2panda/linter/src/lib/FaultAttrs.ts index 85ce65627c..75f7a3e58f 100644 --- a/ets2panda/linter/src/lib/FaultAttrs.ts +++ b/ets2panda/linter/src/lib/FaultAttrs.ts @@ -206,6 +206,7 @@ faultsAttrs[FaultID.InteropJsObjectExpandStaticInstance] = new FaultAttributes(2 faultsAttrs[FaultID.InteropJSFunctionInvoke] = new FaultAttributes(270); faultsAttrs[FaultID.VariableMissingInitializer] = new FaultAttributes(271); faultsAttrs[FaultID.DeprecatedProcessApi] = new FaultAttributes(272); +faultsAttrs[FaultID.NumericUnsignedShiftBehaviorChange] = new FaultAttributes(273); faultsAttrs[FaultID.MissingSuperCall] = new FaultAttributes(274); faultsAttrs[FaultID.CustomLayoutNeedAddDecorator] = new FaultAttributes(275); faultsAttrs[FaultID.InterfaceFieldNotImplemented] = new FaultAttributes(276); diff --git a/ets2panda/linter/src/lib/FaultDesc.ts b/ets2panda/linter/src/lib/FaultDesc.ts index 5f0de591dd..0b22c63bcf 100644 --- a/ets2panda/linter/src/lib/FaultDesc.ts +++ b/ets2panda/linter/src/lib/FaultDesc.ts @@ -266,6 +266,7 @@ faultDesc[FaultID.UnsupportOperator] = 'Unsupport operator'; faultDesc[FaultID.CustomLayoutNeedAddDecorator] = 'Custom layout need add decorator'; faultDesc[FaultID.InterfaceFieldNotImplemented] = 'All fields must be implemented'; faultDesc[FaultID.NoLocalClass] = 'No local classes'; +faultDesc[FaultID.NumericUnsignedShiftBehaviorChange] = 'No right shift on negative numbers'; faultDesc[FaultID.PropDecoratorNotSupported] = '"@Prop" decorator is not supported'; faultDesc[FaultID.StoragePropDecoratorNotSupported] = '"@StorageProp" decorator is not supported'; faultDesc[FaultID.LocalStoragePropDecoratorNotSupported] = '"@LocalStorageProp" decorator is not supported'; diff --git a/ets2panda/linter/src/lib/Problems.ts b/ets2panda/linter/src/lib/Problems.ts index 891835e1cb..3f4e824246 100644 --- a/ets2panda/linter/src/lib/Problems.ts +++ b/ets2panda/linter/src/lib/Problems.ts @@ -264,6 +264,7 @@ export enum FaultID { CustomLayoutNeedAddDecorator, InterfaceFieldNotImplemented, NoLocalClass, + NumericUnsignedShiftBehaviorChange, PropDecoratorNotSupported, StoragePropDecoratorNotSupported, LocalStoragePropDecoratorNotSupported, diff --git a/ets2panda/linter/src/lib/TypeScriptLinter.ts b/ets2panda/linter/src/lib/TypeScriptLinter.ts index 3f2e5be9d6..3e0cca0223 100644 --- a/ets2panda/linter/src/lib/TypeScriptLinter.ts +++ b/ets2panda/linter/src/lib/TypeScriptLinter.ts @@ -2384,6 +2384,7 @@ export class TypeScriptLinter extends BaseTypeScriptLinter { } break; default: + this.handleUnsignedShiftOnNegative(tsBinaryExpr); } this.checkInterOpImportJsDataCompare(tsBinaryExpr); this.checkInteropEqualityJudgment(tsBinaryExpr); @@ -13682,4 +13683,39 @@ export class TypeScriptLinter extends BaseTypeScriptLinter { } } } + + private handleUnsignedShiftOnNegative(node: ts.BinaryExpression): void { + if (!this.options.arkts2) { + return; + } + + if (!TypeScriptLinter.isUnsignedShiftByZero(node)) { + return; + } + + if (TsUtils.isNegativeNumericLiteral(node.left)) { + this.incrementCounters(node, FaultID.NumericUnsignedShiftBehaviorChange); + } + + if (ts.isIdentifier(node.left)) { + const symbol = this.tsTypeChecker.getSymbolAtLocation(node.left); + const decl = symbol?.valueDeclaration; + if (!decl || !ts.isVariableDeclaration(decl)) { + return; + } + + const init = decl.initializer; + if (init && TsUtils.isNegativeNumericLiteral(init)) { + this.incrementCounters(node, FaultID.NumericUnsignedShiftBehaviorChange); + } + } + } + + private static isUnsignedShiftByZero(node: ts.BinaryExpression): boolean { + return ( + node.operatorToken.kind === ts.SyntaxKind.GreaterThanGreaterThanGreaterThanToken && + ts.isNumericLiteral(node.right) && + node.right.text === '0' + ); + } } diff --git a/ets2panda/linter/src/lib/utils/TsUtils.ts b/ets2panda/linter/src/lib/utils/TsUtils.ts index 6eafedeaf4..cee4d36aee 100644 --- a/ets2panda/linter/src/lib/utils/TsUtils.ts +++ b/ets2panda/linter/src/lib/utils/TsUtils.ts @@ -3879,6 +3879,14 @@ export class TsUtils { } } + static isNegativeNumericLiteral(expr: ts.Expression): boolean { + return ( + ts.isPrefixUnaryExpression(expr) && + expr.operator === ts.SyntaxKind.MinusToken && + ts.isNumericLiteral(expr.operand) + ); + } + isNumberArrayType(type: ts.Type): boolean { if (!type.symbol || !this.isGenericArrayType(type)) { return false; diff --git a/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets new file mode 100644 index 0000000000..2841e80f91 --- /dev/null +++ b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets @@ -0,0 +1,26 @@ +/* + * Copyright (c) 2025 Huawei Device Co., Ltd. + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +let a = -123; +let b = 456; +let c = -789; + +let r1 = -123 >>> 0; // error +let r2 = a >>> 0; // error +let r3 = b >>> 0; // valid +let r4 = c >>> 0; // error + +let d = -1; +let r5 = d >>> 0; // error diff --git a/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.args.json b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.args.json new file mode 100644 index 0000000000..d8d3390ad9 --- /dev/null +++ b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.args.json @@ -0,0 +1,19 @@ +{ + "copyright": [ + "Copyright (c) 2025 Huawei Device Co., Ltd.", + "Licensed under the Apache License, Version 2.0 (the 'License');", + "you may not use this file except in compliance with the License.", + "You may obtain a copy of the License at", + "", + "http://www.apache.org/licenses/LICENSE-2.0", + "", + "Unless required by applicable law or agreed to in writing, software", + "distributed under the License is distributed on an 'AS IS' BASIS,", + "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.", + "See the License for the specific language governing permissions and", + "limitations under the License." + ], + "mode": { + "arkts2": "" + } +} \ No newline at end of file diff --git a/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.arkts2.json b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.arkts2.json new file mode 100644 index 0000000000..3862e0bc09 --- /dev/null +++ b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.arkts2.json @@ -0,0 +1,58 @@ +{ + "copyright": [ + "Copyright (c) 2025 Huawei Device Co., Ltd.", + "Licensed under the Apache License, Version 2.0 (the 'License');", + "you may not use this file except in compliance with the License.", + "You may obtain a copy of the License at", + "", + "http://www.apache.org/licenses/LICENSE-2.0", + "", + "Unless required by applicable law or agreed to in writing, software", + "distributed under the License is distributed on an 'AS IS' BASIS,", + "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.", + "See the License for the specific language governing permissions and", + "limitations under the License." + ], + "result": [ + { + "line": 20, + "column": 10, + "endLine": 20, + "endColumn": 20, + "problem": "NumericUnsignedShiftBehaviorChange", + "suggest": "", + "rule": "Unsigned right shift on negative number yields different results in ArkTS versions. (arkts-distinct-unsigned-right-shift-negative-number)", + "severity": "ERROR" + }, + { + "line": 21, + "column": 10, + "endLine": 21, + "endColumn": 17, + "problem": "NumericUnsignedShiftBehaviorChange", + "suggest": "", + "rule": "Unsigned right shift on negative number yields different results in ArkTS versions. (arkts-distinct-unsigned-right-shift-negative-number)", + "severity": "ERROR" + }, + { + "line": 23, + "column": 10, + "endLine": 23, + "endColumn": 17, + "problem": "NumericUnsignedShiftBehaviorChange", + "suggest": "", + "rule": "Unsigned right shift on negative number yields different results in ArkTS versions. (arkts-distinct-unsigned-right-shift-negative-number)", + "severity": "ERROR" + }, + { + "line": 26, + "column": 10, + "endLine": 26, + "endColumn": 17, + "problem": "NumericUnsignedShiftBehaviorChange", + "suggest": "", + "rule": "Unsigned right shift on negative number yields different results in ArkTS versions. (arkts-distinct-unsigned-right-shift-negative-number)", + "severity": "ERROR" + } + ] +} \ No newline at end of file diff --git a/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.json b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.json new file mode 100644 index 0000000000..895325b061 --- /dev/null +++ b/ets2panda/linter/test/main/arkts-unsigned-shift-on-negative.ets.json @@ -0,0 +1,18 @@ +{ + "copyright": [ + "Copyright (c) 2025 Huawei Device Co., Ltd.", + "Licensed under the Apache License, Version 2.0 (the 'License');", + "you may not use this file except in compliance with the License.", + "You may obtain a copy of the License at", + "", + "http://www.apache.org/licenses/LICENSE-2.0", + "", + "Unless required by applicable law or agreed to in writing, software", + "distributed under the License is distributed on an 'AS IS' BASIS,", + "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.", + "See the License for the specific language governing permissions and", + "limitations under the License." + ], + "result": [ + ] +} \ No newline at end of file -- Gitee