From a214a19a5f1f6aae6e4fe213a61ae5e9c090fccf Mon Sep 17 00:00:00 2001 From: crescent Date: Wed, 29 Sep 2021 11:36:29 +0000 Subject: [PATCH] fix magic number Signed-off-by: crescent --- src/host/server_for_client.cpp | 12 ++++++------ src/host/translate.cpp | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/host/server_for_client.cpp b/src/host/server_for_client.cpp index b2dc666a..44745368 100644 --- a/src/host/server_for_client.cpp +++ b/src/host/server_for_client.cpp @@ -403,19 +403,19 @@ bool HdcServerForClient::TaskCommand(HChannel hChannel, void *formatCommandInput uint8_t sizeCmdFlag = 0; if (CMD_FILE_INIT == formatCommand->cmdFlag) { cmdFlag = "send "; - sizeCmdFlag = 5; + sizeCmdFlag = 5; // 5: cmdFlag send size } else if (CMD_FORWARD_INIT == formatCommand->cmdFlag) { cmdFlag = "fport "; - sizeCmdFlag = 6; + sizeCmdFlag = 6; // 6: cmdFlag fport size } else if (CMD_APP_INIT == formatCommand->cmdFlag) { cmdFlag = "install "; - sizeCmdFlag = 8; + sizeCmdFlag = 8; // 8: cmdFlag install size } else if (CMD_APP_UNINSTALL == formatCommand->cmdFlag) { cmdFlag = "uninstall "; - sizeCmdFlag = 10; + sizeCmdFlag = 10; // 10: cmdFlag uninstall size } else if (CMD_UNITY_BUGREPORT_INIT == formatCommand->cmdFlag) { cmdFlag = "bugreport "; - sizeCmdFlag = 10; + sizeCmdFlag = 10; // 10: cmdFlag bugreport size } else if (CMD_APP_SIDELOAD == formatCommand->cmdFlag) { cmdFlag = "sideload "; sizeCmdFlag = 9; @@ -627,7 +627,7 @@ int HdcServerForClient::ReadChannel(HChannel hChannel, uint8_t *bufPtr, const in formatCommand.cmdFlag = CMD_SHELL_DATA; } if (!DoCommand(hChannel, &formatCommand)) { - return -3; // error or want close + return -3; // -3: error or want close } ret = bytesIO; return ret; diff --git a/src/host/translate.cpp b/src/host/translate.cpp index dee385db..150c53c5 100644 --- a/src/host/translate.cpp +++ b/src/host/translate.cpp @@ -100,7 +100,7 @@ namespace TranslateCommand { outCmd->cmdFlag = CMD_KERNEL_TARGET_DISCONNECT; } else { outCmd->cmdFlag = CMD_KERNEL_TARGET_CONNECT; - if (outCmd->paraments.size() > 22) { // tcp max=21,USB max=8bytes + if (outCmd->paraments.size() > 22) { // 22: tcp max=21,USB max=8bytes stringError = "Error connect key's size"; outCmd->bJumpDo = true; } @@ -214,7 +214,7 @@ namespace TranslateCommand { } else if (!strncmp(input, CMDSTR_FILE_SEND.c_str(), CMDSTR_FILE_SEND.size()) || !strncmp(input, CMDSTR_FILE_RECV.c_str(), CMDSTR_FILE_RECV.size())) { outCmd->cmdFlag = CMD_FILE_INIT; - outCmd->paraments = input + 5; // CMDSTR_FORWARD_FPORT CMDSTR_FORWARD_RPORT size + outCmd->paraments = input + 5; // 5: CMDSTR_FORWARD_FPORT CMDSTR_FORWARD_RPORT size } else if (!strncmp(input, string(CMDSTR_FORWARD_FPORT + " ").c_str(), CMDSTR_FORWARD_FPORT.size() + 1) || !strncmp(input, string(CMDSTR_FORWARD_RPORT + " ").c_str(), CMDSTR_FORWARD_RPORT.size() + 1)) { stringError = ForwardPort(input, outCmd); -- Gitee