From 22f3782ba5919dcef9dfa2000bc5f4db72fd4392 Mon Sep 17 00:00:00 2001
From: w30042960 <wangyupan1@huawei.com>
Date: Tue, 21 May 2024 14:39:09 +0800
Subject: [PATCH] modify ut

Signed-off-by: w30042960 <wangyupan1@huawei.com>
---
 .../managersink/src/daudio_sink_dev_test.cpp  | 19 +++++++++++----
 .../src/daudio_sink_manager_test.cpp          | 24 ++++++++++++++-----
 2 files changed, 33 insertions(+), 10 deletions(-)

diff --git a/services/audiomanager/test/unittest/managersink/src/daudio_sink_dev_test.cpp b/services/audiomanager/test/unittest/managersink/src/daudio_sink_dev_test.cpp
index 2137073c..7047ff58 100644
--- a/services/audiomanager/test/unittest/managersink/src/daudio_sink_dev_test.cpp
+++ b/services/audiomanager/test/unittest/managersink/src/daudio_sink_dev_test.cpp
@@ -218,12 +218,23 @@ HWTEST_F(DAudioSinkDevTest, ParseDhidFromEvent_001, TestSize.Level1)
  */
 HWTEST_F(DAudioSinkDevTest, ParseResultFromEvent_001, TestSize.Level1)
 {
-    std::string args = "{\"result\":\"0\"}";
-    EXPECT_EQ(DH_SUCCESS, sinkDev_->ParseResultFromEvent(args));
-    args = "{\"result\":\"-40001\"}";
-    EXPECT_EQ(-40001, sinkDev_->ParseResultFromEvent(args));
+    std::string args = "{\"result\":\"-40001\"}";
+    EXPECT_EQ(-1, sinkDev_->ParseResultFromEvent(args));
     std::string dhIdArgs = "{\"result\": 1 }";
     EXPECT_NE(DH_SUCCESS, sinkDev_->ParseResultFromEvent(dhIdArgs));
+
+    cJSON *jobject = cJSON_CreateObject();
+    CHECK_NULL_VOID(jobject);
+    cJSON_AddNumberToObject(jobject, KEY_RESULT, 0);
+    char *jsonData = cJSON_PrintUnformatted(jobject);
+    if (jsonData == nullptr) {
+        cJSON_Delete(jobject);
+        return;
+    }
+    std::string args1(jsonData);
+    cJSON_free(jsonData);
+    cJSON_Delete(jobject);
+    EXPECT_EQ(DH_SUCCESS, sinkDev_->ParseResultFromEvent(args1));
 }
 
 
diff --git a/services/audiomanager/test/unittest/managersink/src/daudio_sink_manager_test.cpp b/services/audiomanager/test/unittest/managersink/src/daudio_sink_manager_test.cpp
index cecadeb5..80533729 100644
--- a/services/audiomanager/test/unittest/managersink/src/daudio_sink_manager_test.cpp
+++ b/services/audiomanager/test/unittest/managersink/src/daudio_sink_manager_test.cpp
@@ -116,14 +116,14 @@ HWTEST_F(DAudioSinkManagerTest, CreateAudioDevice_001, TestSize.Level1)
     }
     sptr<DAudioSinkIpcCallbackProxy> dAudioSinkIpcCallbackProxy(new DAudioSinkIpcCallbackProxy(remoteObject));
     daudioSinkManager.ipcSinkCallback_ = dAudioSinkIpcCallbackProxy;
-    EXPECT_EQ(ERR_DH_AUDIO_FAILED, daudioSinkManager.CreateAudioDevice(devId));
+    EXPECT_EQ(ERR_DH_AUDIO_NOT_SUPPORT, daudioSinkManager.CreateAudioDevice(devId));
     daudioSinkManager.audioDevMap_.emplace(devId, nullptr);
-    EXPECT_EQ(ERR_DH_AUDIO_FAILED, daudioSinkManager.CreateAudioDevice(devId));
+    EXPECT_EQ(ERR_DH_AUDIO_NOT_SUPPORT, daudioSinkManager.CreateAudioDevice(devId));
     daudioSinkManager.channelState_ = ChannelState::SPK_CONTROL_OPENED;
-    EXPECT_EQ(ERR_DH_AUDIO_FAILED, daudioSinkManager.CreateAudioDevice(devId));
+    EXPECT_EQ(DH_SUCCESS, daudioSinkManager.CreateAudioDevice(devId));
     daudioSinkManager.ClearAudioDev(devId);
     daudioSinkManager.channelState_ = ChannelState::MIC_CONTROL_OPENED;
-    EXPECT_EQ(ERR_DH_AUDIO_FAILED, daudioSinkManager.CreateAudioDevice(devId));
+    EXPECT_EQ(DH_SUCCESS, daudioSinkManager.CreateAudioDevice(devId));
 }
 
 /**
@@ -135,10 +135,22 @@ HWTEST_F(DAudioSinkManagerTest, CreateAudioDevice_001, TestSize.Level1)
 HWTEST_F(DAudioSinkManagerTest, InitAudioDevice_001, TestSize.Level1)
 {
     std::string devId = "1";
+    std::string params = "params";
     std::shared_ptr<DAudioSinkDev> dev = nullptr;
     EXPECT_NE(DH_SUCCESS, daudioSinkManager.InitAudioDevice(dev, devId, true));
-    sptr<IDAudioSinkIpcCallback> callback = nullptr;
-    dev = std::make_shared<DAudioSinkDev>(devId, callback);
+    auto samgr = SystemAbilityManagerClient::GetInstance().GetSystemAbilityManager();
+    if (samgr == nullptr) {
+        return;
+    }
+    sptr<DAudioSinkLoadCallback> loadCallback(new DAudioSinkLoadCallback(params));
+    samgr->LoadSystemAbility(DISTRIBUTED_HARDWARE_AUDIO_SINK_SA_ID, loadCallback);
+    sptr<IRemoteObject> remoteObject = samgr->GetSystemAbility(DISTRIBUTED_HARDWARE_AUDIO_SINK_SA_ID);
+    if (remoteObject == nullptr) {
+        return;
+    }
+    sptr<DAudioSinkIpcCallbackProxy> dAudioSinkIpcCallbackProxy(new DAudioSinkIpcCallbackProxy(remoteObject));
+    daudioSinkManager.ipcSinkCallback_ = dAudioSinkIpcCallbackProxy;
+    dev = std::make_shared<DAudioSinkDev>(devId, dAudioSinkIpcCallbackProxy);
     EXPECT_NE(DH_SUCCESS, daudioSinkManager.InitAudioDevice(dev, devId, true));
     EXPECT_NE(DH_SUCCESS, daudioSinkManager.InitAudioDevice(dev, devId, false));
 }
-- 
Gitee