From 47668e102d945b31964ca3b61b71f654a2b53403 Mon Sep 17 00:00:00 2001
From: wangchaole <wangchaole1@huawei.com>
Date: Wed, 10 Aug 2022 17:27:35 +0800
Subject: [PATCH] fix: reviewbot

Signed-off-by: wangchaole <wangchaole1@huawei.com>
---
 .../client/include/dcamera_client.h           |  1 +
 .../client/src/dcamera_client.cpp             | 19 +++++++++++--------
 .../client/src/dcamera_client_common.cpp      |  6 ++++++
 3 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/services/cameraservice/cameraoperator/client/include/dcamera_client.h b/services/cameraservice/cameraoperator/client/include/dcamera_client.h
index 1bf9d23b..d0b1df0d 100644
--- a/services/cameraservice/cameraoperator/client/include/dcamera_client.h
+++ b/services/cameraservice/cameraoperator/client/include/dcamera_client.h
@@ -66,6 +66,7 @@ private:
         std::shared_ptr<CameraStandard::PhotoCaptureSetting>& photoCaptureSetting);
     void ReleaseCaptureSession();
     int32_t CameraServiceErrorType(const int32_t errorType);
+    void UpdateSettingCache(const std::string& metadataStr);
 
 private:
     constexpr static uint32_t DCAMERA_MAX_METADATA_SIZE = 20;
diff --git a/services/cameraservice/cameraoperator/client/src/dcamera_client.cpp b/services/cameraservice/cameraoperator/client/src/dcamera_client.cpp
index 985abdf6..d28b1764 100644
--- a/services/cameraservice/cameraoperator/client/src/dcamera_client.cpp
+++ b/services/cameraservice/cameraoperator/client/src/dcamera_client.cpp
@@ -99,18 +99,11 @@ int32_t DCameraClient::UpdateSettings(std::vector<std::shared_ptr<DCameraSetting
                 std::string dcSettingValue = setting->value_;
                 std::string metadataStr = Base64Decode(dcSettingValue);
                 FindCameraMetadata(metadataStr);
-
                 if (cameraInput_ == nullptr) {
                     DHLOGE("DCameraClient::UpdateSettings %s cameraInput is null", GetAnonyString(cameraId_).c_str());
-                    if (cameraMetadatas_.size() == DCAMERA_MAX_METADATA_SIZE) {
-                        DHLOGE("DCameraClient::UpdateSettings %s camera metadata oversize",
-                            GetAnonyString(cameraId_).c_str());
-                        cameraMetadatas_.pop();
-                    }
-                    cameraMetadatas_.push(metadataStr);
+                    UpdateSettingCache(metadataStr);
                     return DCAMERA_OK;
                 }
-
                 int32_t ret = ((sptr<CameraStandard::CameraInput> &)cameraInput_)->SetCameraSettings(metadataStr);
                 if (ret != DCAMERA_OK) {
                     DHLOGE("DCameraClient::UpdateSettings %s update metadata settings failed, ret: %d",
@@ -129,6 +122,16 @@ int32_t DCameraClient::UpdateSettings(std::vector<std::shared_ptr<DCameraSetting
     return DCAMERA_OK;
 }
 
+void DCameraClient::UpdateSettingCache(const std::string& metadataStr)
+{
+    if (cameraMetadatas_.size() == DCAMERA_MAX_METADATA_SIZE) {
+        DHLOGE("DCameraClient::UpdateSettings %s camera metadata oversize",
+            GetAnonyString(cameraId_).c_str());
+        cameraMetadatas_.pop();
+    }
+    cameraMetadatas_.push(metadataStr);
+}
+
 void DCameraClient::FindCameraMetadata(const std::string& metadataStr)
 {
     std::shared_ptr<Camera::CameraMetadata> cameraMetadata = Camera::MetadataUtils::DecodeFromString(metadataStr);
diff --git a/services/cameraservice/cameraoperator/client/src/dcamera_client_common.cpp b/services/cameraservice/cameraoperator/client/src/dcamera_client_common.cpp
index f1c0bc19..c2f351d8 100644
--- a/services/cameraservice/cameraoperator/client/src/dcamera_client_common.cpp
+++ b/services/cameraservice/cameraoperator/client/src/dcamera_client_common.cpp
@@ -103,6 +103,7 @@ int32_t DCameraClient::UpdateSettings(std::vector<std::shared_ptr<DCameraSetting
                 if (cameraInput_ == nullptr) {
                     DHLOGE("DCameraClientCommon::UpdateSettings %s cameraInput is null",
                         GetAnonyString(cameraId_).c_str());
+                    UpdateSettingCache(metadataStr);
                     return DCAMERA_BAD_VALUE;
                 }
 
@@ -124,6 +125,11 @@ int32_t DCameraClient::UpdateSettings(std::vector<std::shared_ptr<DCameraSetting
     return DCAMERA_OK;
 }
 
+void DCameraClient::UpdateSettingCache(const std::string& metadataStr)
+{
+    DHLOGE("DCameraClientCommon::UpdateSettingCache metadataStr %s", GetAnonyString(metadataStr).c_str());
+}
+
 void DCameraClient::FindCameraMetadata(const std::string& metadataStr)
 {
     DHLOGI("DCameraClient::FindCameraMetadata cameraId: %s", GetAnonyString(cameraId_).c_str());
-- 
Gitee