diff --git a/lib/cookie.c b/lib/cookie.c index 573edf657503a51f24ed18bad363bcdea5ed9d2a..9b8feefc51cd010ffce43870912fbe3bf337eaa6 100644 --- a/lib/cookie.c +++ b/lib/cookie.c @@ -430,6 +430,30 @@ static bool bad_domain(const char *domain) return !strchr(domain, '.') && !strcasecompare(domain, "localhost"); } +/* + RFC 6265 section 4.1.1 says a server should accept this range: + + cookie-octet = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E + + But Firefox and Chrome as of June 2022 accept space, comma and double-quotes + fine. The prime reason for filtering out control bytes is that some HTTP + servers return 400 for requests that contain such. +*/ +static int invalid_octets(const char *p) +{ + /* Reject all bytes \x01 - \x1f (*except* \x09, TAB) + \x7f */ + static const char badoctets[] = { + "\x01\x02\x03\x04\x05\x06\x07\x08\x0a" + "\x0b\x0c\x0d\x0e\x0f\x10\x11\x12\x13\x14" + "\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f\x7f" + }; + size_t vlen, len; + /* scan for all the octets that are *not* in cookie-octet */ + len = strcspn(p, badoctets); + vlen = strlen(p); + return (len != vlen); +} + /* * Curl_cookie_add * @@ -582,6 +606,11 @@ Curl_cookie_add(struct Curl_easy *data, badcookie = TRUE; break; } + if(invalid_octets(whatptr) || invalid_octets(name)) { + infof(data, "invalid octets in name/value, cookie dropped"); + badcookie = TRUE; + break; + } } else if(!len) { /* diff --git a/tests/data/test8 b/tests/data/test8 index a8548e6c2ea5a49a898e1e3a0576bd016c55b406..783854ae5ce5df5b061213ebada1f41c283a2ed9 100644 --- a/tests/data/test8 +++ b/tests/data/test8 @@ -46,6 +46,36 @@ Set-Cookie: trailingspace = removed; path=/we/want; Set-Cookie: nocookie=yes; path=/WE; Set-Cookie: blexp=yesyes; domain=%HOSTIP; domain=%HOSTIP; expiry=totally bad; Set-Cookie: partialip=nono; domain=.0.0.1; +Set-Cookie: cookie1=%hex[%01-junk]hex% +Set-Cookie: cookie2=%hex[%02-junk]hex% +Set-Cookie: cookie3=%hex[%03-junk]hex% +Set-Cookie: cookie4=%hex[%04-junk]hex% +Set-Cookie: cookie5=%hex[%05-junk]hex% +Set-Cookie: cookie6=%hex[%06-junk]hex% +Set-Cookie: cookie7=%hex[%07-junk]hex% +Set-Cookie: cookie8=%hex[%08-junk]hex% +Set-Cookie: cookie9=%hex[junk-%09-]hex% +Set-Cookie: cookie11=%hex[%0b-junk]hex% +Set-Cookie: cookie12=%hex[%0c-junk]hex% +Set-Cookie: cookie14=%hex[%0e-junk]hex% +Set-Cookie: cookie15=%hex[%0f-junk]hex% +Set-Cookie: cookie16=%hex[%10-junk]hex% +Set-Cookie: cookie17=%hex[%11-junk]hex% +Set-Cookie: cookie18=%hex[%12-junk]hex% +Set-Cookie: cookie19=%hex[%13-junk]hex% +Set-Cookie: cookie20=%hex[%14-junk]hex% +Set-Cookie: cookie21=%hex[%15-junk]hex% +Set-Cookie: cookie22=%hex[%16-junk]hex% +Set-Cookie: cookie23=%hex[%17-junk]hex% +Set-Cookie: cookie24=%hex[%18-junk]hex% +Set-Cookie: cookie25=%hex[%19-junk]hex% +Set-Cookie: cookie26=%hex[%1a-junk]hex% +Set-Cookie: cookie27=%hex[%1b-junk]hex% +Set-Cookie: cookie28=%hex[%1c-junk]hex% +Set-Cookie: cookie29=%hex[%1d-junk]hex% +Set-Cookie: cookie30=%hex[%1e-junk]hex% +Set-Cookie: cookie31=%hex[%1f-junk]hex% +Set-Cookie: cookie31=%hex[%7f-junk]hex% @@ -60,7 +90,7 @@ GET /we/want/%TESTNUMBER HTTP/1.1 Host: %HOSTIP:%HTTPPORT User-Agent: curl/%VERSION Accept: */* -Cookie: name with space=is weird but; trailingspace=removed; cookie=perhaps; cookie=yes; foobar=name; blexp=yesyes +Cookie: name with space=is weird but; trailingspace=removed; cookie=perhaps; cookie=yes; foobar=name; blexp=yesyes; cookie9=junk- -