Watch 759 Star 1.2K Fork 338

开源中国 / Gitee FeedbackRuby

PR支持类似github的reviews评审

任务
待办的
Gitee owner  Opened this issue

关于github的review协同请参考官方文档:https://help.github.com/articles/about-pull-request-reviews/

A review has three possible statuses:

  • Comment: Submit general feedback without explicitly approving the changes or requesting additional changes.
  • Approve: Submit feedback and approve merging the changes proposed in the pull request.
  • Request changes: Submit feedback that must be addressed before the pull request can be merged.

输入图片说明

Attachments
58426 yashin 1578915792 1 oschina org 1578913704 total 3 participants

Comments (5)

shellwalker 2019-02-13 10:40

@Yashin 这个问题gitee是否考虑支持?

58426 yashin 1578915792
Yashin 2019-02-13 10:51

@shellwalker 码云将会对PR review 功能进行改造,敬请期待,也欢迎更具体的细节建议哦

shellwalker 2019-02-13 14:56

@Yashin
建议如下:
gitee的jenkins插件的自动构建结果能够自动给PR设置一个构建的结果(打分,类似gerrit里面的 verified,表示代码已验证过),默认情况下未构建(或构建失败),PR的合并按钮是 disabled 不可操作的;
PR review里面要有多个角色的分级,来完成关键操作,比如:
管理员:修改构建结果(verified结果)
reviewer:给构建结果打分+1,+2
CMO:合并代码(一般情况下就是管理员,但是职责分开更合适)

可以参考一下gerrit里面的角色来设计;

58426 yashin 1578915792
Yashin 2019-02-13 17:03

@shellwalker 很好的建议哈

shellwalker 2019-02-27 10:53

gitlab的这个可以参考一下 merge_when_pipeline_succeeds

Sign in to comment

Assignees
Labels
Not set
Projects
Milestones
Branches
Planed to start
Not set
Planed to end
Not set
Top level
Priority
Ruby
1
https://gitee.com/oschina/git-osc.git
git@gitee.com:oschina/git-osc.git
oschina
git-osc
Gitee Feedback

Search

231008 48f1a665 1899542 231017 9a6720c6 1899542