diff --git a/backport-qnetd-Add-note-about-coverity-false-positive-err.patch b/backport-qnetd-Add-note-about-coverity-false-positive-err.patch new file mode 100644 index 0000000000000000000000000000000000000000..a84b5939413db38ef178bc64c31c234061fce3b7 --- /dev/null +++ b/backport-qnetd-Add-note-about-coverity-false-positive-err.patch @@ -0,0 +1,32 @@ +From f6642ec5c726ba8cf6c3b5e01f861125d910ee6a Mon Sep 17 00:00:00 2001 +From: Jan Friesse +Date: Mon, 5 Aug 2024 17:58:45 +0200 +Subject: [PATCH 3/3] qnetd: Add note about coverity false positive err + +Not too keen to add coverity specific comment as described in +https://community.synopsys.com/s/article/ +Suppressing-False-Positive-Intentional-defects but it's handy to have +note in code. + +Signed-off-by: Jan Friesse +--- + qdevices/qnetd-cluster-list.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/qdevices/qnetd-cluster-list.c b/qdevices/qnetd-cluster-list.c +index 69e4f91..6d4aa6c 100644 +--- a/qdevices/qnetd-cluster-list.c ++++ b/qdevices/qnetd-cluster-list.c +@@ -111,6 +111,9 @@ qnetd_cluster_list_add_client(struct qnetd_cluster_list *list, struct qnetd_clie + } + + if (entry == NULL) { ++ /* ++ * Coverity reports false positive var_deref_op error on following line ++ */ + TAILQ_INSERT_TAIL(&cluster->client_list, client, cluster_entries); + } + +-- +2.33.1.windows.1 + diff --git a/corosync-qdevice.spec b/corosync-qdevice.spec index 3de90f8bd1eefe24d7349757a5d8a9870b8eb566..d48822b0f14c034e8e218cd0c932758a660a8a23 100644 --- a/corosync-qdevice.spec +++ b/corosync-qdevice.spec @@ -11,10 +11,11 @@ Name: corosync-qdevice Summary: The Corosync Cluster Engine Qdevice Version: 3.0.3 -Release: 1 +Release: 2 License: BSD-3-Clause URL: https://github.com/corosync/corosync-qdevice Source0: https://github.com/corosync/corosync-qdevice/releases/download/v%{version}%{?gittarver}/%{name}-%{version}%{?gittarver}.tar.gz +Patch0: backport-qnetd-Add-note-about-coverity-false-positive-err.patch # Runtime bits Requires: corosync >= 2.4.0 @@ -45,6 +46,7 @@ BuildRequires: make %prep %setup -q -n %{name}-%{version}%{?gittarver} +%autopatch -p1 %build %if %{with runautogen} @@ -207,6 +209,9 @@ fi %{_mandir}/man8/corosync-qnetd.8* %changelog +* Fri Oct 18 2024 liupei - 3.0.3-2 +- qnetd: Add note about coverity false positive err + * Tue Feb 27 2024 jiangxinyu - 3.0.3-1 - Upgrade version to 3.0.3