diff --git a/0001-fix-CVE-2024-24786.patch b/0001-fix-CVE-2024-24786.patch new file mode 100644 index 0000000000000000000000000000000000000000..dd79b26b781eb994d32cd676e32035955a9c9ff1 --- /dev/null +++ b/0001-fix-CVE-2024-24786.patch @@ -0,0 +1,59 @@ +From 171172b7a8a24104415f1d461da7a839dd9933a3 Mon Sep 17 00:00:00 2001 +From: bwzhang +Date: Mon, 25 Mar 2024 10:47:11 +0800 +Subject: [PATCH] fix CVE-2024-24786 + +encoding/protojson, internal/encoding/json: handle missing object values + +In internal/encoding/json, report an error when encountering a } +when we are expecting an object field value. For example, the input + now correctly results in an error at the closing } token. + +In encoding/protojson, check for an unexpected EOF token in +skipJSONValue. This is redundant with the check in internal/encoding/json, +but adds a bit more defense against any other similar bugs that +might exist. + +Fixes CVE-2024-24786 + +Change-Id: I03d52512acb5091c8549e31ca74541d57e56c99d +Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/569356 +TryBot-Bypass: Damien Neil +Reviewed-by: Roland Shoemaker +Commit-Queue: Damien Neil +--- + .../protobuf/encoding/protojson/well_known_types.go | 4 ++++ + .../protobuf/internal/encoding/json/decode.go | 2 +- + 2 files changed, 5 insertions(+), 1 deletion(-) + +diff --git a/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go b/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go +index 72924a9..d3825ba 100644 +--- a/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go ++++ b/vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go +@@ -328,6 +328,10 @@ func (d decoder) skipJSONValue() error { + if err := d.skipJSONValue(); err != nil { + return err + } ++ case json.EOF: ++ // This can only happen if there's a bug in Decoder.Read. ++ // Avoid an infinite loop if this does happen. ++ return errors.New("unexpected EOF") + } + } + +diff --git a/vendor/google.golang.org/protobuf/internal/encoding/json/decode.go b/vendor/google.golang.org/protobuf/internal/encoding/json/decode.go +index b13fd29..b2be4e8 100644 +--- a/vendor/google.golang.org/protobuf/internal/encoding/json/decode.go ++++ b/vendor/google.golang.org/protobuf/internal/encoding/json/decode.go +@@ -121,7 +121,7 @@ func (d *Decoder) Read() (Token, error) { + + case ObjectClose: + if len(d.openStack) == 0 || +- d.lastToken.kind == comma || ++ d.lastToken.kind&(Name|comma) != 0 || + d.openStack[len(d.openStack)-1] != ObjectOpen { + return Token{}, d.newSyntaxError(tok.pos, unexpectedFmt, tok.RawString()) + } +-- +2.20.1 + diff --git a/cri-tools.spec b/cri-tools.spec index 0676afca8cba7c0af6236f1fbbf3032a5f3c3bff..ff482c8eed1ddfd2b8052ac8585d18af656d7263 100644 --- a/cri-tools.spec +++ b/cri-tools.spec @@ -13,12 +13,15 @@ Name: cri-tools Version: 1.29.0 -Release: 1 +Release: 2 Summary: CLI and validation tools for Container Runtime Interface License: ASL 2.0 URL: https://%{goipath} Source0: https://github.com/kubernetes-sigs/cri-tools/archive/refs/tags/v%{version}.tar.gz Source1: https://github.com/cpuguy83/go-md2man/archive/refs/tags/v2.0.3.tar.gz + +Patch0001: 0001-fix-CVE-2024-24786.patch + ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm} ppc64le s390x} BuildRequires: golang, glibc-static, git Provides: crictl = %{version}-%{release} @@ -27,7 +30,7 @@ Provides: crictl = %{version}-%{release} %{summary} %prep -%setup -q +%autosetup -p1 -n %{name}-%{version} tar -xf %SOURCE1 %build @@ -60,6 +63,12 @@ install -p -m 644 docs/crictl.1 %{buildroot}%{_mandir}/man1 %{_mandir}/man1/crictl* %changelog +* Wed Apr 10 2024 zhangbowei - 1.29.0-2 +- Type:bugfix +- CVE:NA +- SUG:NA +- DESC: fix CVE-2024-24786 + * Wed Feb 28 2024 lijian - 1.29.0-1 - update to 1.29.0