From 3ac67e8f047c329cab261b11a87276d9dcae8254 Mon Sep 17 00:00:00 2001 From: happyworker <208suo@208suo.com> Date: Tue, 8 Jul 2025 14:54:54 +0800 Subject: [PATCH] CVE-2024-35365 --- backport-CVE-2024-35365.patch | 57 +++++++++++++++++++++++++++++++++++ ffmpeg.spec | 7 ++++- 2 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 backport-CVE-2024-35365.patch diff --git a/backport-CVE-2024-35365.patch b/backport-CVE-2024-35365.patch new file mode 100644 index 0000000..9a488db --- /dev/null +++ b/backport-CVE-2024-35365.patch @@ -0,0 +1,57 @@ +From ced5c5fdb8634d39ca9472a2026b2d2fea16c4e5 Mon Sep 17 00:00:00 2001 +From: Andreas Rheinhardt +Date: Mon, 25 Mar 2024 16:54:25 +0100 +Subject: [PATCH] fftools/ffmpeg_mux_init: Fix double-free on error + +MATCH_PER_STREAM_OPT iterates over all options of a given +OptionDef and tests whether they apply to the current stream; +if so, they are set to ost->apad, otherwise, the code errors +out. If no error happens, ost->apad is av_strdup'ed in order +to take ownership of this pointer. + +But this means that setting it originally was premature, +as it leads to double-frees when an error happens lateron. +This can simply be reproduced with +ffmpeg -filter_complex anullsrc -apad bar -apad:n baz -f null - +This is a regression since 83ace80bfd80fcdba2c65fa1d554923ea931d5bd. + +Fix this by using a temporary variable instead of directly +setting ost->apad. Also only strdup the string if it actually +is != NULL. + +Reviewed-by: Marth64 +Signed-off-by: Andreas Rheinhardt +--- + fftools/ffmpeg_mux_init.c | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c +index 63a25a3..e0220ef 100644 +--- a/fftools/ffmpeg_mux_init.c ++++ b/fftools/ffmpeg_mux_init.c +@@ -845,6 +845,7 @@ static int new_stream_audio(Muxer *mux, const OptionsContext *o, + int channels = 0; + char *layout = NULL; + char *sample_fmt = NULL; ++ const char *apad = NULL; + + MATCH_PER_STREAM_OPT(audio_channels, i, channels, oc, st); + if (channels) { +@@ -882,8 +883,12 @@ static int new_stream_audio(Muxer *mux, const OptionsContext *o, + + MATCH_PER_STREAM_OPT(audio_sample_rate, i, audio_enc->sample_rate, oc, st); + +- MATCH_PER_STREAM_OPT(apad, str, ost->apad, oc, st); +- ost->apad = av_strdup(ost->apad); ++ MATCH_PER_STREAM_OPT(apad, str, apad, oc, st); ++ if (apad) { ++ ost->apad = av_strdup(apad); ++ if (!ost->apad) ++ return AVERROR(ENOMEM); ++ } + + #if FFMPEG_OPT_MAP_CHANNEL + /* check for channel mapping for this audio stream */ +-- +2.46.0 + diff --git a/ffmpeg.spec b/ffmpeg.spec index c0a25fb..2b328b9 100644 --- a/ffmpeg.spec +++ b/ffmpeg.spec @@ -62,7 +62,7 @@ Summary: Digital VCR and streaming server Name: ffmpeg%{?flavor} Version: 6.1.1 -Release: 21 +Release: 22 License: GPL-3.0-or-later URL: http://ffmpeg.org/ Source0: http://ffmpeg.org/releases/ffmpeg-%{version}.tar.xz @@ -88,6 +88,7 @@ Patch17: backport-CVE-2024-36619.patch Patch18: backport-CVE-2024-35369.patch Patch19: backport-CVE-2024-36613.patch Patch20: CVE-2025-25473.patch +Patch21: backport-CVE-2024-35365.patch Requires: %{name}-libs%{?_isa} = %{version}-%{release} %{?_with_cuda:BuildRequires: cuda-minimal-build-%{_cuda_version_rpm} cuda-drivers-devel} @@ -420,6 +421,10 @@ install -pm755 tools/qt-faststart %{buildroot}%{_bindir} %changelog + +* Tue Apr 22 2025 changtao - 6.1.1-22 +- fix CVE-2024-35365 + * Tue Apr 22 2025 happyworker <208suo@208suo.com> - 6.1.1-21 - fix CVE-2025-25473 -- Gitee