diff --git a/backport-CVE-2024-9632.patch b/backport-CVE-2024-9632.patch new file mode 100644 index 0000000000000000000000000000000000000000..f47803f259e89124057b84fff4a2325cb971ab7b --- /dev/null +++ b/backport-CVE-2024-9632.patch @@ -0,0 +1,57 @@ +From 85b776571487f52e756f68a069c768757369bfe3 Mon Sep 17 00:00:00 2001 +From: Matthieu Herrb +Date: Thu, 10 Oct 2024 10:37:28 +0200 +Subject: [PATCH] xkb: Fix buffer overflow in _XkbSetCompatMap() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +origin: https://gitlab.freedesktop.org/xorg/xserver/-/commit/85b776571487f52e756f68a069c768757369bfe3 + +The _XkbSetCompatMap() function attempts to resize the `sym_interpret` +buffer. + +However, It didn't update its size properly. It updated `num_si` only, +without updating `size_si`. + +This may lead to local privilege escalation if the server is run as root +or remote code execution (e.g. x11 over ssh). + +CVE-2024-9632, ZDI-CAN-24756 + +This vulnerability was discovered by: +Jan-Niklas Sohn working with Trend Micro Zero Day Initiative + +Reviewed-by: Peter Hutterer +Tested-by: Peter Hutterer +Reviewed-by: José Expósito +Part-of: +--- + xkb/xkb.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/xkb/xkb.c b/xkb/xkb.c +index 868d7c1e64..aaf9716b36 100644 +--- a/xkb/xkb.c ++++ b/xkb/xkb.c +@@ -2990,13 +2990,13 @@ _XkbSetCompatMap(ClientPtr client, DeviceIntPtr dev, + XkbSymInterpretPtr sym; + unsigned int skipped = 0; + +- if ((unsigned) (req->firstSI + req->nSI) > compat->num_si) { +- compat->num_si = req->firstSI + req->nSI; ++ if ((unsigned) (req->firstSI + req->nSI) > compat->size_si) { ++ compat->num_si = compat->size_si = req->firstSI + req->nSI; + compat->sym_interpret = reallocarray(compat->sym_interpret, +- compat->num_si, ++ compat->size_si, + sizeof(XkbSymInterpretRec)); + if (!compat->sym_interpret) { +- compat->num_si = 0; ++ compat->num_si = compat->size_si = 0; + return BadAlloc; + } + } +-- +GitLab + diff --git a/xorg-x11-server.spec b/xorg-x11-server.spec index bc9bdbc8e095ef451409ef06a9a99caab7b66abb..3822419e03c3b9f02c795275d52e9b5d90089bc8 100644 --- a/xorg-x11-server.spec +++ b/xorg-x11-server.spec @@ -16,7 +16,7 @@ Name: xorg-x11-server Version: 1.20.8 -Release: 30 +Release: 31 Summary: X.Org X11 X server License: MIT and GPLv2 URL: https://www.x.org @@ -132,6 +132,7 @@ Patch6039: backport-dix-fix-valuator-copy-paste-error-in-the-DeviceState.patch Patch6040: backport-0001-CVE-2023-5574.patch Patch6041: backport-0002-CVE-2023-5574.patch Patch6042: backport-0003-CVE-2023-5574.patch +Patch6043: backport-CVE-2024-9632.patch BuildRequires: audit-libs-devel autoconf automake bison dbus-devel flex flex-devel git gcc BuildRequires: systemtap-sdt-devel libtool pkgconfig @@ -375,6 +376,9 @@ find %{inst_srcdir}/hw/xfree86 -name \*.c -delete %{_libdir}/xorg/protocol.txt %changelog +* Mon Nov 04 2024 wangkai <13474090681@163.com> - 1.20.8-31 +- Fix CVE-2024-9632 + * Fri Oct 25 2024 lingsheng - 1.20.8-30 - Type:CVE - CVE:CVE-2023-5574