同步社区补丁

<h3></h3>回合如下8个社区补丁<table ><tr><td colSpan="1" rowSpan="1">CommitId</td><td colSpan="1" rowSpan="1">描述</td></tr><tr><td colSpan="1" rowSpan="1">4c16416ebc5f0958d58a1ea1e7890eafd9f8bb75</td><td colSpan="1" rowSpan="1">port: fix OVERRUN &#x60;&#x60;&#x60;shadow-4.15.0/lib/port.c:154:2: alias: Assigning: port.pt_names = ttys. port.pt_names now points to element 0 of ttys .173| *cp = &#x27;\0&#x27;;174| cp++;175|-&gt; port.pt_names[j + 1] = NULL;176|177| /*&#x60;&#x60;&#x60; Resolves: https://issues.redhat.com/browse/RHEL-35383 Signed-off-by: Iker PedrosaReviewed-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">71a3238b7996285fc3c8dec841244ba95d663fa5</td><td colSpan="1" rowSpan="1">src/usermod.c: update_gshadow_fileReport:&gt; shadow-4.15.0/src/usermod.c:864:3: alloc_fn: Storage is returned from allocation function __sgr_dup.&gt; shadow-4.15.0/src/usermod.c:864:3: var_assign: Assigning: nsgrp = storage returned from __sgr_dup;&gt; 963| }&gt; 964|-&gt; }&gt; 965| #endif /* SHADOWGRP */&gt; 966| Link: https://issues.redhat.com/browse/RHEL-35383Reported-by: Iker PedrosaSigned-off-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">1ee066ae1e5b39ac42120ad0f6f8af0f102db952</td><td colSpan="1" rowSpan="1">src/useradd.c: set_defaults: Fix FILE* leakReport:&gt; shadow-4.15.0/src/useradd.c:575:2: alloc_fn: Storage is returned from allocation function fdopen.&gt; shadow-4.15.0/src/useradd.c:575:2: var_assign: Assigning: ofp = storage returned from fdopen.&gt; shadow-4.15.0/src/useradd.c:734:2: leaked_storage: Variable ofp going out of scope leaks the storage it points to.&gt; 732| }&gt; 733|&gt; 734|-&gt; return ret;&gt; 735| }&gt; 736| Resources should be freed in the inverse order of the allocation.This refactor prepares for the following commits, which fix some leaks. Reviewed-by: Iker PedrosaSigned-off-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">701fe4cf1aeac9e66fa949369c91d135dbf375d2</td><td colSpan="1" rowSpan="1">src/useradd.c: set_defaults if it failedSee asprintf: RETURN VALUEWhen successful, these functions return the number of bytesprinted, just like sprintf. If memory allocation wasn’t possi‐ble, or some other error occurs, these functions will return -1,and the contents of strp are undefined. Reviewed-by: Iker PedrosaSigned-off-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">e7d1508e076bbf4053faacc0370c6fe43d9c8f04</td><td colSpan="1" rowSpan="1">src/useradd.c: Add fmkstemp to fix file-descriptor leakThis function creates a temporary file, and returns a FILE pointer toit. This avoids dealing with both a file descriptor and a FILE pointer,and correctly deallocating the resources on error. The code before this patch was leaking the file descriptor if fdopenfailed. Reviewed-by: Iker PedrosaSigned-off-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">61964aa06b9e6e0643a6519f64290f18ac04867f</td><td colSpan="1" rowSpan="1">src/usermod.c: update_group_fileReport:&gt; shadow-4.15.0/src/usermod.c:734:3: alloc_fn: Storage is returned from allocation function __gr_dup.&gt; shadow-4.15.0/src/usermod.c:734:3: var_assign: Assigning: ngrp = storage returned from __gr_dup;&gt; 814| }&gt; 815|-&gt; }&gt; 816|&gt; 817| #ifdef SHADOWGRP Link: https://issues.redhat.com/browse/RHEL-35383Reported-by: Iker PedrosaSigned-off-by: Alejandro Colomar</td></tr><tr><td colSpan="1" rowSpan="1">10429edc14673fbb8c78b25f1872c34e88e5f07f</td><td colSpan="1" rowSpan="1">src/groupmod.c: delete gr_free_members to avoid double freeGroupmod -U may cause crashes because of double free. If without -a, the first free of to avoid double free.Although this may seem reckless, the second free in two different positions will definitely be triggered, and the following two test cases can be used to illustrate the situation : [root@localhost src]# ./useradd u1[root@localhost src]# ./useradd u2[root@localhost src]# ./useradd u3[root@localhost src]# ./groupadd -U u1,u2,u3 g1[root@localhost src]# ./groupmod -n g2 -U u1,u2 g1Segmentation fault This case would free .gr_mem again. [root@localhost src]# ./useradd u1[root@localhost src]# ./useradd u2[root@localhost src]# ./useradd u3[root@localhost src]# ./groupadd -U u1,u2,u3 g1[root@localhost src]# ./groupmod -U u1,u2 g1Segmentation fault The other case would free .gr_mem again. So the first free is unnecessary, maybe we can drop it. Fixes: 342c934a3590 Closes:Link:Link:Link:Cc: Serge E. HallynReviewed-by: Alejandro ColomarSigned-off-by: lixinyun</td></tr></table>

src-openEuler/shadow

内容风险标识

评论 (4)

src-openEuler/shadow .gitee-modal { width: 500px !important; }

内容风险标识