Sign in
Sign up
Explore
Enterprise
Education
Search
Help
Terms of use
About Us
Explore
Enterprise
Education
Gitee Premium
Gitee AI
AI teammates
Sign in
Sign up
Fetch the repository succeeded.
description of repo status
Open Source
>
Other
>
Operation System
&&
Donate
Please sign in before you donate.
Cancel
Sign in
Scan WeChat QR to Pay
Cancel
Complete
Prompt
Switch to Alipay.
OK
Cancel
Watch
Unwatch
Watching
Releases Only
Ignoring
458
Star
1.7K
Fork
1.9K
GVP
openEuler
/
kernel
Closed
Code
Issues
1271
Pull Requests
991
Wiki
Insights
Pipelines
Service
Quality Analysis
Jenkins for Gitee
Tencent CloudBase
Tencent Cloud Serverless
悬镜安全
Aliyun SAE
Codeblitz
SBOM
DevLens
Don’t show this again
Update failed. Please try again later!
Remove this flag
Content Risk Flag
This task is identified by
as the content contains sensitive information such as code security bugs, privacy leaks, etc., so it is only accessible to contributors of this repository.
blk-mq: fix null pointer dereference in blk_mq_queue_tag_busy_ite
Done
#I617GN
Bug
Li Nan
member
Opened this issue
2022-11-15 11:13
【环境信息】 硬件信息:不涉及 软件信息:openEuler-22.03-LTS、OLK-5.10 【问题描述】 在初始化dm时,register_disk()中将dm加入class链表后即可在/proc/diskstats读取dm的io统计数据 register_disk device_add klist_add_tail(&dev->p->knode_class,&dev->class->p->klist_devices); 但此时dm queue可能还未初始化完成,若在设置queue的ops之后、tag_set之前读取io统计数据,会因为访问q->tag_set而导致空指针访问,如下: CPU0 CPU1 dm_mq_init_request_queue md->tag_set = kzalloc_node blk_mq_init_allocated_queue q->mq_ops = set->ops; diskstats_show part_get_stat_info if(q->mq_ops) blk_mq_in_flight_with_stat blk_mq_queue_tag_busy_ite if (blk_mq_is_shared_tags(q->tag_set->flags)) //q->tag_set is null here q->tag_set = set blk_register_queue blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q) cat /sys/block/[device]/inflight时也会产生同样问题。 修复方案:在queue初始化完成后,会置高标志位:QUEUE_FLAG_REGISTERED 所以在进行统计前,检查QUEUE_FLAG_REGISTERED确保queue初始化完成,通过/proc/diskstats和/sys/block/[device]/inflight 查看io统计都会进入函数blk_mq_queue_tag_busy_iter,所以在该函数中进行检查 【后续修复】 在上述补丁中如果queue未初始化完成,blk_mq_queue_tag_busy_iter()将直接返回 而一些scsi驱动(如ata_piix)在初始化期间会依赖blk_mq_timeout_work()来完成io,所以这类驱动无法初始化完成。 对QUEUE_FLAG_REGISTERED的检查放至调用者中,避开blk_mq_timeout_work。
【环境信息】 硬件信息:不涉及 软件信息:openEuler-22.03-LTS、OLK-5.10 【问题描述】 在初始化dm时,register_disk()中将dm加入class链表后即可在/proc/diskstats读取dm的io统计数据 register_disk device_add klist_add_tail(&dev->p->knode_class,&dev->class->p->klist_devices); 但此时dm queue可能还未初始化完成,若在设置queue的ops之后、tag_set之前读取io统计数据,会因为访问q->tag_set而导致空指针访问,如下: CPU0 CPU1 dm_mq_init_request_queue md->tag_set = kzalloc_node blk_mq_init_allocated_queue q->mq_ops = set->ops; diskstats_show part_get_stat_info if(q->mq_ops) blk_mq_in_flight_with_stat blk_mq_queue_tag_busy_ite if (blk_mq_is_shared_tags(q->tag_set->flags)) //q->tag_set is null here q->tag_set = set blk_register_queue blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q) cat /sys/block/[device]/inflight时也会产生同样问题。 修复方案:在queue初始化完成后,会置高标志位:QUEUE_FLAG_REGISTERED 所以在进行统计前,检查QUEUE_FLAG_REGISTERED确保queue初始化完成,通过/proc/diskstats和/sys/block/[device]/inflight 查看io统计都会进入函数blk_mq_queue_tag_busy_iter,所以在该函数中进行检查 【后续修复】 在上述补丁中如果queue未初始化完成,blk_mq_queue_tag_busy_iter()将直接返回 而一些scsi驱动(如ata_piix)在初始化期间会依赖blk_mq_timeout_work()来完成io,所以这类驱动无法初始化完成。 对QUEUE_FLAG_REGISTERED的检查放至调用者中,避开blk_mq_timeout_work。
Comments (
1
)
Sign in
to comment
Status
Done
Backlog
已挂起
Fixing
Confirmed
Done
Accepted
Canceled
Assignees
Not set
Labels
sig/Kernel
Not set
Projects
Unprojected
Unprojected
Pull Requests
None yet
None yet
Successfully merging a pull request will close this issue.
Branches
No related branch
Branches (
-
)
Tags (
-
)
Planed to start   -   Planed to end
-
Top level
Not Top
Top Level: High
Top Level: Medium
Top Level: Low
Priority
Not specified
Serious
Main
Secondary
Unimportant
Duration
(hours)
参与者(2)
C
1
https://gitee.com/openeuler/kernel.git
git@gitee.com:openeuler/kernel.git
openeuler
kernel
kernel
Going to Help Center
Search
Git 命令在线学习
如何在 Gitee 导入 GitHub 仓库
Git 仓库基础操作
企业版和社区版功能对比
SSH 公钥设置
如何处理代码冲突
仓库体积过大,如何减小?
如何找回被删除的仓库数据
Gitee 产品配额说明
GitHub仓库快速导入Gitee及同步更新
什么是 Release(发行版)
将 PHP 项目自动发布到 packagist.org
Comment
Repository Report
Back to the top
Login prompt
This operation requires login to the code cloud account. Please log in before operating.
Go to login
No account. Register