[5.10] tcp: Fix listen() regression in 5.10.163 · Pull Request !1475 · anolis/cloud-kernel

bugzilla: https://bugzilla.openanolis.cn/show_bug.cgi?id=4510

When we backport dadd0dcaa67d ("net/ulp: prevent ULP without clone op from
entering the LISTEN status"), we have accidentally backported a part of
7a7160edf1bf ("net: Return errno in sk->sk_prot->get_port().") and removed
err = -EADDRINUSE in inet_csk_listen_start().

Thus, listen() no longer returns -EADDRINUSE even if ->get_port() failed
as reported in [0].

We set -EADDRINUSE to err just before ->get_port() to fix the regression.

TEST(reuseaddr_ports_exhausted_reusable_different_euid)
{
        struct reuse_opts *opts;
        int i, j, ret, fd[2];
        uid_t euid[2] = {10, 20};

for (i = 0; i < 4; i++) {
                opts = &reusable_opts[i];

for (j = 0; j < 2; j++) {
                        ret = seteuid(euid[j]);
                        ASSERT_EQ(0, ret) TH_LOG("failed to seteuid: %d.", euid[j]);

fd[j] = bind_port(_metadata, opts->reuseaddr[j], opts->reuseport[j]);

ret = seteuid(0);
                        ASSERT_EQ(0, ret) TH_LOG("failed to seteuid: 0.");
                }

ASSERT_NE(-1, fd[0]) TH_LOG("failed to bind.");
                EXPECT_NE(-1, fd[1]) TH_LOG("should succeed to bind because one socket can be bound in each euid.");

if (fd[1] != -1) {
                        ret = listen(fd[0], 5);
                        ASSERT_EQ(0, ret) TH_LOG("failed to listen.");

ret = listen(fd[1], 5);
                        EXPECT_EQ(-1, ret) TH_LOG("should fail to listen because only one uid reserves the port in TCP_LISTEN.");  ---用例在此fail

类型	指派人员	状态
审查	Xuan Zhuo	已完成 (0/0人)
测试	小龙已测试通过	已完成 (1/1人)

GVPanolis / cloud-kernel

搜索帮助

GVP anolis / cloud-kernel