[sync] PR-890: ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce() · Pull Request !900 · openEuler/kernel

### 1. Origin pull request:
https://gitee.com/openeuler/kernel/pulls/890

### 2. Original pull request related issue(s):
https://gitee.com/openeuler/kernel/issues/I7A2A0

### 3. Original pull request related commit(s):
| Sha | Datetime | Message |
|---|---|---|
|[b7355a31](https://gitee.com/openeuler/kernel/commits/b7355a314c849e0f61bbbc4c60d7cccd2fd7cf59)|2023-06-02 15:24:33 +0800 CST|ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce() mainline inclusion from mainline-v5.16-rc3 commit 0276af2176c78771da7f311621a25d7608045827 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I7A2A0 CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0276af2176c78771da7f311621a25d7608045827 -------------------------------- ethtool_set_coalesce() now uses both the .get_coalesce() and .set_coalesce() callbacks. But the check for their availability is buggy, so changing the coalesce settings on a device where the driver provides only _one_ of the callbacks results in a NULL pointer dereference instead of an -EOPNOTSUPP. Fix the condition so that the availability of both callbacks is ensured. This also matches the netlink code. Note that reproducing this requires some effort - it only affects the legacy ioctl path, and needs a specific combination of driver options: - have .get_coalesce() and .coalesce_supported but no .set_coalesce(), or - have .set_coalesce() but no .get_coalesce(). Here eg. ethtool doesn't cause the crash as it first attempts to call ethtool_get_coalesce() and bails out on error. Fixes: f3ccfda19319 ("ethtool: extend coalesce setting uAPI with CQE mode") Cc: Yufeng Mo <moyufeng@huawei.com> Cc: Huazhong Tan <tanhuazhong@huawei.com> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com> Link: https://lore.kernel.org/r/20211126175543.28000-1-jwi@linux.ibm.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> |

GVPopenEuler/kernel关闭

搜索帮助

GVP openEuler/kernel
关闭